[asterisk-dev] [Code Review] menuselect by support level categories

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1524/#review4509
-----------------------------------------------------------



/trunk/menuselect.c
<https://reviewboard.asterisk.org/r/1524/#comment8684>

    This function is actually no longer necessary thanks to the addition of initialize_separator and find_or_initialize_separators.  It's a remnant from earlier work.


- jrose


On Oct. 13, 2011, 12:46 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1524/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2011, 12:46 p.m.)
> 
> 
> Review request for Asterisk Developers, Kevin Fleming and David Vossel.
> 
> 
> Summary
> -------
> 
> Changes menuselect applications so that they can reorder member lists from category trees so that they get separated by support level.  Also adds separators splitting the selection groups in an easy to visually parse manner.
> 
> Just applying this patch won't perfectly sort every item.  Items that don't receive labels are dumped into an 'other' category, but appear in menuselect as having core support.  Another review will be posted which cleans up support level tags so that these will appear in the right place.
> 
> Fixes are made against cmenuselect, nmenuselect, and gmenuselect (which turns out to still work after the latest round of changes).
> 
> One issue with gmenuselect is that the checkboxes for disabling/enabling members are still visible.  Clicking on them doesn't do anything, but their appearance remains annoying.  It's not really any kind of big problem though.
> 
> In addition to these, a couple long-standing bugs in the cmenuselect easteregg were fixed.  One prevented the use of the 'q' key to return to the main menu. The other involves setting a certain value back to zero if the easteregg is ran multiple times in a single session.
> 
> I'm still unsure whether this change should be made against the menuselect in 1.8 or if it should just apply to later versions of Asterisk.  The report's description wasn't sure either.
> 
> 
> This addresses bug ASTERISK-18268.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18268
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect.c 943 
>   /trunk/menuselect.h 943 
>   /trunk/menuselect_curses.c 943 
>   /trunk/menuselect_gtk.c 943 
>   /trunk/menuselect_newt.c 943 
> 
> Diff: https://reviewboard.asterisk.org/r/1524/diff
> 
> 
> Testing
> -------
> 
> Made sure all existing modules made the list.
> Made sure disabling/enabling separators wouldn't work.
> Made sure modules being enabled did in fact enable those specific modules.
> Made sure menuselect didn't produce unusual error messages.
> 
> This change could probably do with some more extensive testing, and I'm sure there are probably some quirks with the way I went about doing this.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111013/e5ad4fc1/attachment-0001.htm>