[asterisk-dev] [Code Review] "sipusers" only exists in documentation, and "sipfriends" is still used in documentation

wdoekes reviewboard at asterisk.org
Thu Oct 13 03:33:54 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1523/
-----------------------------------------------------------

Review request for Asterisk Developers and Terry Wilson.


Summary
-------

Since 1.6(.2?), "sipusers" has been gone from chan_sip. I suspect sippeers now does what sipfriends was supposed to do again, but changing the preferred the name back to sipfriends again sounds like a bad plan.

This patch removes all leftover references to sipusers and renames sipfriends to sippeers where possible.

(Reviewboard didn't let me upload the patch with 'svn mv ...sipfriends.sql ...sippeer.sql' , but the file should be renamed as well.)


Diffs
-----

  branches/1.8/contrib/realtime/mysql/sipfriends.sql 340769 
  branches/1.8/main/config.c 340769 
  branches/1.8/res/res_realtime.c 340769 
  branches/1.8/contrib/realtime/mysql/sipfriends.sql 340769 
  branches/1.8/configs/dbsep.conf.sample 340769 
  branches/1.8/configs/extconfig.conf.sample 340769 
  branches/1.8/configs/res_config_mysql.conf.sample 340769 
  branches/1.8/configs/res_ldap.conf.sample 340769 

Diff: https://reviewboard.asterisk.org/r/1523/diff


Testing
-------

None whatsoever, but the only code changes involve removing 1 line and editing documentation strings.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111013/a86592c3/attachment.htm>


More information about the asterisk-dev mailing list