[asterisk-dev] [Code Review]: Store route-set from provisional SIP responses so early-dialog requests can be routed properly

[Kevin Fleming]

> On Oct. 11, 2011, 9:46 a.m., Olle E Johansson wrote:
> > Just a statement without checking the code (on my way between two meetings). The route set in a 180 is temporary for the early dialog. When we get the 200 the dialog starts and we can no longer change the route set. Just observe that the route set may change after the 180, but never after the 200.

Yep... this patch does the right thing. It parses the supplied Contact and Route headers for 1xx responses that we process (other than '100 Trying'), but does not do so if the original request was a re-INVITE. It also does not change the behavior for '200 OK' final responses that confirm the dialog.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1505/#review4495
-----------------------------------------------------------


On Oct. 11, 2011, 10:22 a.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1505/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2011, 10:22 a.m.)
> 
> 
> Review request for Asterisk Developers and Olle E Johansson.
> 
> 
> Summary
> -------
> 
> i have found a problem with a blond transfer and connected_line UPDATE messages. 
> When doing a transfer to a ringing channel the UPDATE message will not have any route information attached cause the route header is only parsed on a 200 response and not on a 180.
> 
> this small patch parses the contact header and also sets the proper route information even on a 180 respsonse so when an UPDATE messages is sent out, the route header is attached.
> 
> maybe doing the same for a 183 response would also be a good idea.
> 
> 
> Diffs
> -----
> 
>   team/schmidts/unleash-the-beast/channels/chan_sip.c 340107 
> 
> Diff: https://reviewboard.asterisk.org/r/1505/diff
> 
> 
> Testing
> -------
> 
> asterisk is behind a kamailio sip proxy which drops in-dialog messages with no prober route header. after parsing the route header of a 180 reponse the proxy forwards the information to the right end point.
> 
> normal transfer, blind transfer, ringing ... works fine.
> 
> CONNECTED_LINE function after the transfer also works like expected.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111011/4c75a26c/attachment.htm>