[asterisk-dev] [Code Review] Load the proper XML documentation when multiple modules document the same application

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1485/#review4489
-----------------------------------------------------------

Ship it!


Fire away


/branches/1.8/include/asterisk/module.h
<https://reviewboard.asterisk.org/r/1485/#comment8670>

    /*!



/branches/1.8/main/xmldoc.c
<https://reviewboard.asterisk.org/r/1485/#comment8672>

    "(and support for multiple languages should actually work now)"
    
    Ah. I see. Good. I was wondering why it worked before... it didn't ;)


- wdoekes


On Oct. 6, 2011, 12:54 p.m., Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1485/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2011, 12:54 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds an option "module" attribute to the XML documentation spec that allows the documentation processor to match apps with identical names from different modules to their documentation. This patch also fixes a number of bugs with the documentation processor and should make it a little more efficient (and support for multiple languages should actually work now).
> 
> 
> This addresses bug ASTERISK-18130.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18130
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_fax.c 339624 
>   /branches/1.8/doc/appdocsxml.dtd 339624 
>   /branches/1.8/include/asterisk/module.h 339624 
>   /branches/1.8/include/asterisk/xmldoc.h 339624 
>   /branches/1.8/main/loader.c 339624 
>   /branches/1.8/main/manager.c 339624 
>   /branches/1.8/main/pbx.c 339624 
>   /branches/1.8/main/xmldoc.c 339624 
>   /branches/1.8/res/res_agi.c 339624 
>   /branches/1.8/res/res_fax.c 339624 
> 
> Diff: https://reviewboard.asterisk.org/r/1485/diff
> 
> 
> Testing
> -------
> 
> Tested on my test box. Works and doesn't break anything.
> 
> 
> Thanks,
> 
> Matthew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111007/ee395e4d/attachment.htm>