[asterisk-dev] [Code Review] Load the proper XML documentation when multiple modules document the same application

Matthew Nicholson reviewboard at asterisk.org
Wed Oct 5 12:09:02 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1485/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch adds an option "module" attribute to the XML documentation spec that allows the documentation processor to match apps with identical names from different modules to their documentation. This patch also fixes a number of bugs with the documentation processor and should make it a little more efficient (and support for multiple languages should actually work now).


This addresses bug ASTERISK-18130.
    https://issues.asterisk.org/jira/browse/ASTERISK-18130


Diffs
-----

  /branches/1.8/apps/app_fax.c 339509 
  /branches/1.8/doc/appdocsxml.dtd 339509 
  /branches/1.8/include/asterisk/module.h 339509 
  /branches/1.8/include/asterisk/xmldoc.h 339509 
  /branches/1.8/main/loader.c 339509 
  /branches/1.8/main/manager.c 339509 
  /branches/1.8/main/pbx.c 339509 
  /branches/1.8/main/xmldoc.c 339509 
  /branches/1.8/res/res_agi.c 339509 
  /branches/1.8/res/res_fax.c 339509 

Diff: https://reviewboard.asterisk.org/r/1485/diff


Testing
-------

Tested on my test box. Works and doesn't break anything.


Thanks,

Matthew

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111005/0ea922d8/attachment.htm>


More information about the asterisk-dev mailing list