[asterisk-dev] [Code Review]: update samples to use [public] context

rmudgett reviewboard at asterisk.org
Wed Nov 30 19:33:34 CST 2011



> On Nov. 30, 2011, 7:21 p.m., Tilghman Lesher wrote:
> > trunk/configs/chan_dahdi.conf.sample, line 56
> > <https://reviewboard.asterisk.org/r/719/diff/2/?file=22028#file22028line56>
> >
> >     I think this should remain as "incoming", for the simple reason that most users starting up with DAHDI will be using analog lines and the "s" extension, which doesn't jibe well with DID used with other channel drivers.

It was commented out before so the "incoming" context was not used and incoming calls were dumped into the default context.  Also the description line above was changed to explicitly state incoming calls go here.  This just makes the sample configs consistent.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/719/#review4895
-----------------------------------------------------------


On Nov. 30, 2011, 4:42 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/719/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 4:42 p.m.)
> 
> 
> Review request for Asterisk Developers, Tilghman Lesher and Alec Davis.
> 
> 
> Summary
> -------
> 
> This was an important topic last year, but has since faded into the night.  I've updated the patch from the original issue plus some documentation Leif posted to the list.
> 
> ---
> http://lists.digium.com/pipermail/asterisk-dev/2009-November/040392.html
> http://lists.digium.com/pipermail/asterisk-dev/2009-November/040555.html
> 
> 
> This addresses bug 15101.
>     https://issues.asterisk.org/jira/browse/15101
> 
> 
> Diffs
> -----
> 
>   trunk/configs/chan_dahdi.conf.sample 345773 
>   trunk/configs/chan_ooh323.conf.sample 345773 
>   trunk/configs/extensions.conf.sample 345773 
>   trunk/configs/extensions.lua.sample 345773 
>   trunk/configs/iax.conf.sample 345773 
>   trunk/configs/sip.conf.sample 345773 
>   trunk/configs/vpb.conf.sample 345773 
> 
> Diff: https://reviewboard.asterisk.org/r/719/diff
> 
> 
> Testing
> -------
> 
> compile testing
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111201/fd16b60e/attachment.htm>


More information about the asterisk-dev mailing list