[asterisk-dev] [Code Review]: rtp / rtcp set debug ip doesnt work correctly in 1.8

[schmidts]

> On Nov. 28, 2011, 7:25 a.m., wdoekes wrote:
> > branches/1.8/res/res_rtp_asterisk.c, line 2773
> > <https://reviewboard.asterisk.org/r/1600/diff/2/?file=21923#file21923line2773>
> >
> >     Did this compile? I don't see the declaration of debughost/debugport.
> >     
> >     In any case, I'd do it like rtp_do_debug_ip above.

copy and paste error, thanks for noticing ;)


> On Nov. 28, 2011, 7:25 a.m., wdoekes wrote:
> > branches/1.8/res/res_rtp_asterisk.c, line 322
> > <https://reviewboard.asterisk.org/r/1600/diff/2/?file=21923#file21923line322>
> >
> >     I would remove the unneeded parentheses here, but you may choose to keep them.

it looks cleaner for me cause the return value is inverted.


> On Nov. 28, 2011, 7:25 a.m., wdoekes wrote:
> > branches/1.8/res/res_rtp_asterisk.c, lines 2744-2748
> > <https://reviewboard.asterisk.org/r/1600/diff/2/?file=21923#file21923line2744>
> >
> >     Combine this into a single condition:
> >     
> >     if (!ast_sockaddr_parse || !ast_sockaddr_split)
> >     
> >     (And the function call could use some spaces.)

i had it first the way you say, but it didnt work proberbly. I will try to change it this way, maybe i have done something wrong.


- schmidts


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1600/#review4873
-----------------------------------------------------------


On Nov. 28, 2011, 6:11 a.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1600/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2011, 6:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In 1.8 rtp and rtcp set debug ip also needs a port to work. if you only use for example rtp set debug ip 10.10.10.10 then it would look for 10.10.10.10 port 0 and will not show any rtp packets regarding this ip coming to another port.
> 
> regarding to the Usage output of rtp set debug ip the port is optional and not necessary.
> 
> by adding a check if a port is present we can use the right compare function. ast_sockaddr_cmp or ast_sockaddr_cmp_addr
> 
> 
> This addresses bug ASTERISK-18693.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18693
> 
> 
> Diffs
> -----
> 
>   branches/1.8/res/res_rtp_asterisk.c 346291 
> 
> Diff: https://reviewboard.asterisk.org/r/1600/diff
> 
> 
> Testing
> -------
> 
> tested with rtp set debug ip with and without port and it works like expected.
> 
> rtcp set debug ip also works.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111128/cecccbe4/attachment.htm>