[asterisk-dev] [Code Review] Fix more res_jabber resource leaks

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1553/#review4842
-----------------------------------------------------------



trunk/channels/chan_gtalk.c
<https://reviewboard.asterisk.org/r/1553/#comment9029>

    Rather then using buddy_unref, can't you just use:
    if (buddy) {
       ASTOBJ_UNREF(buddy, ast_aji_buddy_destroy);
    }



trunk/channels/chan_jingle.c
<https://reviewboard.asterisk.org/r/1553/#comment9030>

    Same buddy / buddy_unref finding here



trunk/res/res_jabber.c
<https://reviewboard.asterisk.org/r/1553/#comment9031>

    And here (although it is commented out)


- mjordan


On Nov. 1, 2011, 3:15 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1553/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 3:15 p.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Summary
> -------
> 
> There are many resource leaks inside res_jabber caused by uses of ASTOBJ_CONTAINER_FIND without a corresponding UNREF.  This fixes all the instances I saw and additionally fixes aji_client and aji_buddy leaks into chan_gtalk and chan_jingle.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_gtalk.c 342600 
>   trunk/channels/chan_jingle.c 342600 
>   trunk/include/asterisk/jabber.h 342600 
>   trunk/res/res_jabber.c 342600 
> 
> Diff: https://reviewboard.asterisk.org/r/1553/diff
> 
> 
> Testing
> -------
> 
> Tested res_jabber via distributed devstate changes in conjunction with openfire XMPP server.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111122/ce2428ab/attachment.htm>