[asterisk-dev] [Code Review] Change the default nat setting to "yes"

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1591/
-----------------------------------------------------------

(Updated Nov. 21, 2011, 1:04 p.m.)


Review request for Asterisk Developers and Kevin Fleming.


Summary
-------

Change the default to nat=yes, update CHANGES explaining the change, remove nat= from example peers, and add a big warning about having different nat= settings in [general] and peer configs.


This addresses bug ASTERISK-18862.
    https://issues.asterisk.org/jira/browse/ASTERISK-18862


Diffs (updated)
-----

  /branches/1.4/configs/sip.conf.sample 345734 
  /branches/1.4/CHANGES 345734 
  /branches/1.4/channels/chan_sip.c 345734 

Diff: https://reviewboard.asterisk.org/r/1591/diff


Testing
-------

Created users of various nat flavors and verified that the default was changed and that 'sip show peer' reported that nat was set as it should be.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111121/c66e74de/attachment.htm>