[asterisk-dev] [Code Review] Add #includeif statement

Paul Belanger reviewboard at asterisk.org
Mon Nov 21 10:28:24 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1476/
-----------------------------------------------------------

(Updated Nov. 21, 2011, 10:28 a.m.)


Review request for Asterisk Developers and leifmadsen.


Changes
-------

rename to #tryinclude


Summary
-------

Talking with Leif on IRC today, he was asking for a way to include a config file, that might not exist all the time.  Because #include 'foo.conf' to a non existing will fail to load a module, we decided #includeif might be better.

#exec cat foo.conf is another option, however this seems to require more CPU and opens a potential security issue.


Diffs (updated)
-----

  trunk/CHANGES 345734 
  trunk/main/config.c 345734 

Diff: https://reviewboard.asterisk.org/r/1476/diff


Testing
-------

Local development box testing.  A few more testers would be nice :D


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111121/55156ab2/attachment.htm>


More information about the asterisk-dev mailing list