[asterisk-dev] [Code Review] Change the default nat setting to "yes"

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1591/#review4823
-----------------------------------------------------------



/branches/1.4/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1591/#comment8984>

    This is called every time build_peer is called, right? That would get very old very quickly if you're using realtime.



/branches/1.4/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1591/#comment8982>

    s/existant/existent/



/branches/1.4/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/1591/#comment8983>

    I thought default was to have:
    
    ;option=value_that_is_not_default
    
    (sip.conf starts out that way with ;allowguest=no, ;match_auth_username=yes, ;allowtransfer=no)
    
    But later on it seems to be random, so flipping this to yes would be ok. (Unless someone has made a general rule of what would be recommended in the future.)


- wdoekes


On Nov. 18, 2011, 10:50 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1591/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 10:50 a.m.)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Change the default to nat=yes, update CHANGES explaining the change, remove nat= from example peers, and add a big warning about having different nat= settings in [general] and peer configs.
> 
> 
> This addresses bug ASTERISK-18862.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18862
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/configs/sip.conf.sample 345544 
>   /branches/1.4/channels/chan_sip.c 345544 
>   /branches/1.4/CHANGES 345544 
> 
> Diff: https://reviewboard.asterisk.org/r/1591/diff
> 
> 
> Testing
> -------
> 
> Created users of various nat flavors and verified that the default was changed and that 'sip show peer' reported that nat was set as it should be.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111121/f7f3e2a0/attachment.htm>