[asterisk-dev] [Code Review] Change the default nat setting to "yes"

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1591/#review4820
-----------------------------------------------------------



/branches/1.4/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1591/#comment8979>

    What if the global setting is nat=no? You can still set that right? This statement can be a bit confusing.



/branches/1.4/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/1591/#comment8980>

    Same issue here; you're not really being specific that the recommended setting is nat=yes. The note just says that if things are different, they are bad :)


- Leif


On Nov. 18, 2011, 10:50 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1591/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 10:50 a.m.)
> 
> 
> Review request for Asterisk Developers and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Change the default to nat=yes, update CHANGES explaining the change, remove nat= from example peers, and add a big warning about having different nat= settings in [general] and peer configs.
> 
> 
> This addresses bug ASTERISK-18862.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18862
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/configs/sip.conf.sample 345544 
>   /branches/1.4/channels/chan_sip.c 345544 
>   /branches/1.4/CHANGES 345544 
> 
> Diff: https://reviewboard.asterisk.org/r/1591/diff
> 
> 
> Testing
> -------
> 
> Created users of various nat flavors and verified that the default was changed and that 'sip show peer' reported that nat was set as it should be.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111118/4effa950/attachment.htm>