[asterisk-dev] [Code Review] Add mute all participants; play participant count to ConfBridge

mjordan reviewboard at asterisk.org
Thu Nov 17 09:43:46 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 17, 2011, 9:43 a.m.)

Review request for Asterisk Developers and David Vossel.


Updated with description of what the admin_toggle_mute_participants will do, namely, not muting admins in the conference.  This was the clarified as the intended behavior of this feature (see ASTERISK-18204).


This patch adds two new menu features to ConfBridge, admin_toggle_menu_participants and participant_count.  The admin action will globally mute / unmute all participants on a conference, while the participant count simply exposes the existing participant count function to the conference bridge menu.

Note that this is a port of the patch supplied by Kevin Reeves on ASTERISK-18204.  Very minor modifications were made to that patch, including adding sound file overriding to the config parser and some general overall cleanup.

This also makes a minor change that outputs the caller ID of the participants when the CLI command to list a specific conf bridge is used.  As this is useful and a minor modification, it was left in with this patch.

This addresses bug ASTERISK-18204.

Diffs (updated)

  /trunk/apps/confbridge/conf_config_parser.c 345544 
  /trunk/apps/confbridge/include/confbridge.h 345544 
  /trunk/configs/confbridge.conf.sample 345544 
  /trunk/apps/app_confbridge.c 345544 
  /trunk/CHANGES 345544 

Diff: https://reviewboard.asterisk.org/r/1518/diff


Tested using a polycom phone and zoiper softphone.  No sound file quality issues were detecting in playing back the global sound using the conference bridge channel, which was an issue Kevin originally reported with his first implementation.  There did not appear to be any locking issues with the implementation proposed by Kevin.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111117/4852e2c2/attachment.htm>

More information about the asterisk-dev mailing list