[asterisk-dev] [Code Review] Multiple recipients and urgency.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1589/
-----------------------------------------------------------

(Updated Nov. 15, 2011, 3:20 p.m.)


Review request for Asterisk Developers and mjordan.


Changes
-------

Made slightly cleaner by only doing the urgent flag check once and setting a string instead.


Summary
-------

When sending a voicemail with multiple recipients and using the urgent option, all flags applied to the message are copied and should be used in the copy_message function.  Setup was done actually to check whether the message was urgent or not and then to use create_dirpath to set up the appropiate folders, but then a little further down the road make_dir would be invoked in a way that ignores this flag and set the todir to INBOX even when the Urgent flag was raised.  Because of this, the extra recipients would always have their voicemails copied to the inbox folder and if the message was marked as urgent, this would only work if the inbox folder had already been created by previous messages.

One of the bug reports suggests that we should only be sending to the urgent folder on the primary recipient unless the auto forwarding as urgent flag is set, but I maintain that this is not a question of forwarding, which is a whole other feature.  This is simply a message with multiple recipients, and all the flags applied to the message should be honored for this purpose, and the intent for that is pretty clear in the copy_message comment "If urgent, copy to Urgent folder".


This addresses bugs ASTERISK-18245 and ASTERISK-18246.
    https://issues.asterisk.org/jira/browse/ASTERISK-18245
    https://issues.asterisk.org/jira/browse/ASTERISK-18246


Diffs (updated)
-----

  /branches/1.8/apps/app_voicemail.c 345120 

Diff: https://reviewboard.asterisk.org/r/1589/diff


Testing
-------

Tested multiple recipients with the urgent option and without the urgent option.  In both cases, the files are sent to their respective folders.  Also checked to make sure it worked with unmade directory paths each time.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111115/57567b71/attachment.htm>