[asterisk-dev] [Code Review] unbreaking <sip:username> from-uri support for REGISTER

wdoekes reviewboard at asterisk.org
Mon Nov 14 13:45:19 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 14, 2011, 1:45 p.m.)

Review request for Asterisk Developers and Terry Wilson.


Re-add the password parameter to parse_uri because it changes behaviour.


See the bug report: there were some XXX'es in the code about code that should be removed.

The patch does this:

(1) register_verify won't accept a To: without user-part anymore (illegal according to rfc3261, 10.2)

(2) check_user_full still doesn't require a user-part, but it won't match usernames by domain anymore. (i.e. it doesn't treat sip:domain as sip:domain at domain anymore)

(3) there was some freaky logic going on in get_msg_text, I had to rewrite it to make it make sense.

(4) in the reqresp parser there were lots of if (params) inside a big if (params) block. I scrapped the useless if's.

This addresses bug ASTERISK-18389.

Diffs (updated)

  /branches/1.8/channels/chan_sip.c 345163 

Diff: https://reviewboard.asterisk.org/r/1533/diff


It compiles.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111114/b4cadcb5/attachment.htm>

More information about the asterisk-dev mailing list