[asterisk-dev] [Code Review] Restore SIP DTMF overlap dialing method.

rmudgett reviewboard at asterisk.org
Mon Nov 14 11:02:25 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 14, 2011, 11:02 a.m.)

Review request for Asterisk Developers, mjordan and Pavel Troller.


Give credit to Pavel Troller for the initial patch that I started with.

Summary (updated)

See ASTERISK-18702 it has a very good description of the issue.

Basically, the recent fix for ASTERISK-17288 to get RFC3578 SIP overlap support working correctly removed a long standing ability to do overlap dialing using DTMF in the early media phase of a call.

The large change block for PAGE2 flags is just to make room for the now two bit field SIP_PAGE2_ALLOWOVERLAP.

I started with Pavel Troller's chan_sip.diff patch on issue ASTERISK-18702.


* Renames SIP_GET_DEST_PICKUP_EXTEN_FOUND to SIP_GET_DEST_EXTEN_MATCHMORE since that is what it really means.

* Fixed get_destination() inconsistency with the pickup extension matching.

* Fixed initialization of PAGE3 of global_flags in reload_config().

This addresses bugs ASTERISK-17288 and ASTERISK-18702.


  /branches/1.8/channels/sip/include/sip.h 344897 
  /branches/1.8/configs/sip.conf.sample 344897 
  /branches/1.8/channels/chan_sip.c 344897 
  /branches/1.8/CHANGES 344897 

Diff: https://reviewboard.asterisk.org/r/1582/diff


It compiles. :)



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111114/550451d0/attachment-0001.htm>

More information about the asterisk-dev mailing list