[asterisk-dev] [Code Review] Update basic call parking test.

mjordan reviewboard at asterisk.org
Mon Nov 14 15:03:30 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1587/#review4812
-----------------------------------------------------------

Ship it!


Resetting the reactor timeout might be needed on the test agents - other then that, looks good


/asterisk/trunk/tests/callparking/run-test
<https://reviewboard.asterisk.org/r/1587/#comment8971>

    With the multiple tests, how long does the test take to run?  You may want to make a call during each initiate_call_to_park to reset the timeout - see TestCase.reset_timeout()


- mjordan


On Nov. 14, 2011, 1:48 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1587/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2011, 1:48 p.m.)
> 
> 
> Review request for Asterisk Developers and mjordan.
> 
> 
> Summary
> -------
> 
> This test updates the basic call parking external test.
> It now verifies Call Parking by DTMF one-step, DTMF blind xfer, and DTMF atxfer.
> Also tests the features findslot=next parking option.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/callparking/configs/ast1/features.conf 2723 
>   /asterisk/trunk/tests/callparking/configs/ast2/extensions.conf 2723 
>   /asterisk/trunk/tests/callparking/run-test 2723 
>   /asterisk/trunk/tests/callparking/test-config.yaml 2723 
>   /asterisk/trunk/tests/callparking/configs/ast1/extensions.conf 2723 
> 
> Diff: https://reviewboard.asterisk.org/r/1587/diff
> 
> 
> Testing
> -------
> 
> Test passed last time I ran it.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111114/da7898d5/attachment.htm>


More information about the asterisk-dev mailing list