[asterisk-dev] [Code Review] Move password entry for new Comedian Mail users to the end of setup.

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1581/#review4801
-----------------------------------------------------------

Ship it!


Sounds like the right fix.

- wdoekes


On Nov. 11, 2011, 3:46 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1581/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2011, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers and mjordan.
> 
> 
> Summary
> -------
> 
> The reporter (Matt Jordan in this case) mentioned that when using the force name entry and force greeting options in voicemail that a new user can skip those by simply hanging up after password entry and then his password will be set and he never has to bother with those things.  Technically, this is a pretty minor hole since there is also nothing stopping the user from simply being silent during the recordings of those as well, but that's aside the point...
> 
> This patch simply moves password setting to the end of the setup procedure.  I thought about simply not setting the user's password until the end, but doing password entry at the start anyway, but that would do one of the following things...
> 
> A.  Make the Allison voice prompt "password has been changed" a lie, if mentioned immediately after setting password while it was still at the start.
> B.  Make the voice prompt triggered at an awkward moment some time after the password was entered.
> C.  Made us remove the voice prompt because it would either be a lie or unintuitive.
> 
> By moving the password entry to the end, all of that is obviated and this fix is made really simple.
> 
> 
> This addresses bug ASTERISK-18282.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18282
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_voicemail.c 344811 
> 
> Diff: https://reviewboard.asterisk.org/r/1581/diff
> 
> 
> Testing
> -------
> 
> Tested new user entry on voicemail with a number of possible stopping points.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111114/94acc101/attachment.htm>