[asterisk-dev] [Code Review] Don't forget to rescan MOH files for cached realtime MOH classes

Terry Wilson reviewboard at asterisk.org
Fri Nov 11 03:35:15 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1579/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Realtime MOH class caching was implemented because without it, you would build a completely new MOH class and would start the music over at the beginning each time hold was pressed in a conversation. Unfortunately, this broke re-scanning for file changes for realtime MOH classes. This patch corrects that issue.


This addresses bug ASTERISK-18039.
    https://issues.asterisk.org/jira/browse/ASTERISK-18039


Diffs
-----

  /branches/1.8/res/res_musiconhold.c 344438 

Diff: https://reviewboard.asterisk.org/r/1579/diff


Testing
-------

Set cachertclasses=yes and ensured that moh continued between hold presses and that replacing the MOH file caused the next instance of hold to play the new file as expected.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111111/03490db0/attachment.htm>


More information about the asterisk-dev mailing list