[asterisk-dev] [Code Review] fix using external MP3 player and res_timing_dahdi

elguero reviewboard at asterisk.org
Thu Nov 10 22:45:11 CST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.


The attached patch does the following:

- Changes the load priority so that this module is loaded after the timing interfaces are.

At times, res_musichold.so would work with an external mp3 player.  Through debugging, I noticed that res_timing_pthread was being used at first.  If I only loaded res_timing_dahdi, then the external mp3 stream would start and then pause causing nothing to be heard on the channel. So, if res_timing_pthread was present at start, upon reload, since res_timing_dahdi takes priority as a timer, the timing changed to this timing interface and would just sit there, hence the need for the following change.

- Adds the POLLPRI event for ast_poll, otherwise ast_poll just sits there waiting when the timer being used is res_timing_dahdi.so

- Attempt to cleanup a few items

This addresses bug ASTERISK-17474.


  /trunk/res/res_musiconhold.c 344329 

Diff: https://reviewboard.asterisk.org/r/1578/diff


Local box running CentOS 5.7 and dahdi-trunk.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111111/d9e4bef7/attachment.htm>

More information about the asterisk-dev mailing list