[asterisk-dev] [Code Review]: ast_indicate(chan, -1) don't stop playing tones

[rmudgett]

> On Nov. 7, 2011, 12:31 p.m., rmudgett wrote:
> > This patch seems more like a bandaid fix for a channel driver returning an inconsistent value.
> > 
> > You mention dahdi but not what kind of channel.  Chan_dahid supports several channel sub-technologies: analog, MFC/R2, ISDN, SS7.
> 
> may213 wrote:
>     You're right about bandaid fix and channel type was DAHDI PRI. I can fix my problem in dahdi/sig_pri driver but i think patch in this review is more generic way and solve problem for any channel driver. The patch does nothing except call playtones_stop if _condition is negative.

What it does is mask inconsistency problems with the channel driver which is not generic.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1559/#review4718
-----------------------------------------------------------


On Nov. 2, 2011, 2:47 a.m., may213 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1559/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 2:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ast_indicate_data function must call ast_stop_playtones when condition arg is negative, but don't call ast_stop_playtones if indicate function of channel driver return zero result.
> 
> If channel->tech->indicate return zero then processing go to indicate_cleanup before processing negative condition arg, it's bug
> because we must stop tone generator if condition arg is negative independent of returned from tech->indicate value.
> 
> The patch call ast_stop_playtones before processing indicate return value.
> 
> 
> This addresses bug 18803.
>     https://issues.asterisk.org/jira/browse/18803
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/channel.c 338895 
> 
> Diff: https://reviewboard.asterisk.org/r/1559/diff
> 
> 
> Testing
> -------
> 
> app_queue work correctly with 'r' option on dahdi channel with patch.
> 
> 
> Thanks,
> 
> may213
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111109/70fb0140/attachment.htm>