[asterisk-dev] [Code Review] app_voicemail [general] variables zonetag and locale are not set on mailbox until after reload

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1570/#review4727
-----------------------------------------------------------


For tracking purposes, go ahead and file an ASTERISK issue to tie this to.

Have you checked that the unit tests that parse user options still pass?  They really should have caught this (although its difficult for the unit tests to change global static variables without affecting the rest of app_voicemail) - they might need some updating to prevent this kind of thing from happening the next time we add parameters to app_voicemail.


/branches/1.8/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/1570/#comment8909>

    I'd keep these comments.  Its actually somewhat useful to note that we load mailboxes from two different sources, and which ones we're loading them from in which block.  A better comment may be that we load the user mailboxes from users.conf and voicemail.conf, and all global settings should be read prior to this.


- mjordan


On Nov. 8, 2011, 4:58 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1570/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 4:58 a.m.)
> 
> 
> Review request for Asterisk Developers and shawkris.
> 
> 
> Summary
> -------
> 
> shawkris identified the problem that a couple of voicemail variables from [general] are not set on the mailboxes until after a reload.
> 
> I confirmed that: the variables in question are those that are set by populate_defaults(); some of them have not been loaded yet when the mailboxes are created the first time.
> 
> Specifically: the VM_PBXSKIP flag in globalflags, zonetag, locale
> 
> I moved the create-mailbox stuff to after all the settings are loaded so this shouldn't be an issue anymore.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_voicemail.c 343785 
> 
> Diff: https://reviewboard.asterisk.org/r/1570/diff
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111108/daa1dde3/attachment.htm>