[asterisk-dev] [Code Review] Fix deadlock between subscription event RWLOCK and dialogs container lock in chan_sip. (simplified)

rmudgett reviewboard at asterisk.org
Fri Nov 4 17:28:34 CDT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 4, 2011, 5:28 p.m.)

Review request for Asterisk Developers, David Vossel and schmidts.


Made use ao2_callback instead of the iterator.  The ao2_callback makes it look more like the code in Asterisk 10.


Timing between dialog destruction and a MWI event sending a message could result in a deadlock.

Order of events causing deadlock:

1a) The event subscription system calls the registered callbacks with its list RWLOCK held.
1b) The SIP monitor checks for dialogs needing destruction.  It does an ao2_callback that holds the dialogs container lock while searching for dialogs to destroy.
2a) The event subscription SIP callback needs to create a temporary dialog to send out the MWI notification.  That temporary dialog needs to be inserted in the dialogs container so it must wait.
2b) The dialog search finds a dialog to destroy and as a result releases the last reference for a peer.  The peer destructor attempts to get the subscription RWLOCK but must wait.
3) deadlock

This is based off of the original diff posted for review: https://reviewboard.asterisk.org/r/1557/

It directly addresses the comment dvossel posted to the original diff of https://reviewboard.asterisk.org/r/1557/

This addresses bug ASTERISK-18747.

Diffs (updated)

  /branches/1.8/channels/chan_sip.c 343487 

Diff: https://reviewboard.asterisk.org/r/1564/diff


It compiles. :)



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111104/57a18f76/attachment-0001.htm>

More information about the asterisk-dev mailing list