[asterisk-dev] [Code Review]: BLF Subscriptions Causes SIP Deadlock

[mjordan]

> On Nov. 4, 2011, 1:57 p.m., David Vossel wrote:
> > perfect!

Close - we really should use peer_ref / peer_unref for adding ref counts / removing them from the peer.  Makes debugging peer ref counts a bit easier.  There's still a pair of them hanging around line 25006 - I should have dropped a comment on that pair as well.

Probably not worth holding up the commit on though.


- mjordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1563/#review4694
-----------------------------------------------------------


On Nov. 4, 2011, 1 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1563/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2011, 1 p.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> Fix a locking inversion that causes deadlocks during BLF subscriptions.
> 
> 
> This addresses bug ASTERISK-18663.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18663
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 342600 
> 
> Diff: https://reviewboard.asterisk.org/r/1563/diff
> 
> 
> Testing
> -------
> 
> Compile
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111104/707b1abb/attachment.htm>