[asterisk-dev] [Code Review]: BLF Subscriptions Causes SIP Deadlock

[opticron]

> On Nov. 3, 2011, 10:41 a.m., Olle E Johansson wrote:
> > I'm confused. Do we have two different proposals to handle this now?
> > My original patch looked more like this, but then I was recommended to do the opposite. Just make sure we all agree on the right way forward :-)
> >

The patch has been heavily reworked.  I initially started work on this by reverting what seemed to be the offending patch.


> On Nov. 3, 2011, 10:41 a.m., Olle E Johansson wrote:
> > trunk/channels/chan_sip.c, line 25816
> > <https://reviewboard.asterisk.org/r/1563/diff/1/?file=21581#file21581line25816>
> >
> >     Please keep this comment somewhere for the future.

Comment left in place.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1563/#review4659
-----------------------------------------------------------


On Nov. 3, 2011, 10:15 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1563/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 10:15 a.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> Fix a locking inversion that causes deadlocks during BLF subscriptions.  This moves locking back outside of sip_send_mwi_to_peer and adds locking where it was needed.
> 
> 
> This addresses bug ASTERISK-18663.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18663
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 342600 
> 
> Diff: https://reviewboard.asterisk.org/r/1563/diff
> 
> 
> Testing
> -------
> 
> Compile
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111104/9d52cc02/attachment.htm>