[asterisk-dev] [Code Review] Add mute all participants; play participant count to ConfBridge

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1518/#review4646
-----------------------------------------------------------



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1518/#comment8845>

    conference_bridge->muted = conference_bridge->muted ? 0 : 1; is clearer. No reason to negate the logic.



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1518/#comment8846>

    Seems like conf_get_sound(conference_bridge->muted ? CONF_SOUND_PARTICIPANTS_MUTED : CONF_SOUND_PARTICIPANTS_UNMUTED, conference_bridge_user->b_profile.sounds) would save having to duplicate out conf_get_sound function call for both of these.


- Terry


On Oct. 11, 2011, 2:39 p.m., mjordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1518/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2011, 2:39 p.m.)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This patch adds two new menu features to ConfBridge, admin_toggle_menu_participants and participant_count.  The admin action will globally mute / unmute all participants on a conference, while the participant count simply exposes the existing participant count function to the conference bridge menu.
> 
> Note that this is a port of the patch supplied by Kevin Reeves on ASTERISK-18204.  Very minor modifications were made to that patch, including adding sound file overriding to the config parser and some general overall cleanup.
> 
> This also makes a minor change that outputs the caller ID of the participants when the CLI command to list a specific conf bridge is used.  As this is useful and a minor modification, it was left in with this patch.
> 
> 
> This addresses bug ASTERISK-18204.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18204
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/confbridge/include/confbridge.h 340278 
>   /trunk/configs/confbridge.conf.sample 340278 
>   /trunk/apps/confbridge/conf_config_parser.c 340278 
>   /trunk/CHANGES 340278 
>   /trunk/apps/app_confbridge.c 340278 
> 
> Diff: https://reviewboard.asterisk.org/r/1518/diff
> 
> 
> Testing
> -------
> 
> Tested using a polycom phone and zoiper softphone.  No sound file quality issues were detecting in playing back the global sound using the conference bridge channel, which was an issue Kevin originally reported with his first implementation.  There did not appear to be any locking issues with the implementation proposed by Kevin.
> 
> 
> Thanks,
> 
> mjordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111103/df354cb9/attachment-0001.htm>