[asterisk-dev] [Code Review] fix sqlite crash on unset config_table / unbreak sqlite realtime_multi_handler

wdoekes reviewboard at asterisk.org
Wed Nov 2 15:48:09 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1561/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Bugs
https://issues.asterisk.org/jira/browse/ASTERISK-18354 and
https://issues.asterisk.org/jira/browse/ASTERISK-18355
concern crashes and failure to return realtime multientry results.

The bug reports should be self-explanatory, but here's a summary:
(1) config_table is not guaranteed to be non-NULL => crash
(2) multientry lookups assume a 'commented' column exists -- it should only do that if the table == config_table


This addresses bugs ASTERISK-18354 and ASTERISK-18355.
    https://issues.asterisk.org/jira/browse/ASTERISK-18354
    https://issues.asterisk.org/jira/browse/ASTERISK-18355


Diffs
-----

  /branches/1.8/res/res_config_sqlite.c 343156 

Diff: https://reviewboard.asterisk.org/r/1561/diff


Testing
-------


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111102/e3039d83/attachment.htm>


More information about the asterisk-dev mailing list