[asterisk-dev] [Code Review] ast_indicate(chan, -1) don't stop playing tones

may213 reviewboard at asterisk.org
Wed Nov 2 02:47:19 CDT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 2, 2011, 2:47 a.m.)

Review request for Asterisk Developers.

Summary (updated)

ast_indicate_data function must call ast_stop_playtones when condition arg is negative, but don't call ast_stop_playtones if indicate function of channel driver return zero result.

If channel->tech->indicate return zero then processing go to indicate_cleanup before processing negative condition arg, it's bug
because we must stop tone generator if condition arg is negative independent of returned from tech->indicate value.

The patch call ast_stop_playtones before processing indicate return value.

This addresses bug 18803.


  branches/1.8/main/channel.c 338895 

Diff: https://reviewboard.asterisk.org/r/1559/diff


app_queue work correctly with 'r' option on dahdi channel with patch.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111102/f08e4485/attachment.htm>

More information about the asterisk-dev mailing list