[asterisk-dev] [Code Review] Adds barriers to the menuselect easter egg

jrose reviewboard at asterisk.org
Tue Nov 1 15:24:37 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1556/#review4630
-----------------------------------------------------------



/trunk/menuselect_curses.c
<https://reviewboard.asterisk.org/r/1556/#comment8831>

    red space



/trunk/menuselect_curses.c
<https://reviewboard.asterisk.org/r/1556/#comment8832>

    red space



/trunk/menuselect_curses.c
<https://reviewboard.asterisk.org/r/1556/#comment8833>

    red space



/trunk/menuselect_curses.c
<https://reviewboard.asterisk.org/r/1556/#comment8834>

    red space
    



/trunk/menuselect_curses.c
<https://reviewboard.asterisk.org/r/1556/#comment8835>

    opening and closing braces.



/trunk/menuselect_curses.c
<https://reviewboard.asterisk.org/r/1556/#comment8836>

    go ahead and kill this red space since you are around the area.


- jrose


On Nov. 1, 2011, 3:23 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1556/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 3:23 p.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel and jrose.
> 
> 
> Summary
> -------
> 
> Adds barriers to the cmenuselect easteregg.  They absorb shots, but fall apart quickly.  Also has support for different amounts of health on barriers, but this is currently set to one shot, one barrier killed.
> 
> Submitted by proxy for J'Len Dowdy.
> 
> 
> This addresses bug ASTERISK-18802.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18802
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect_curses.c 953 
> 
> Diff: https://reviewboard.asterisk.org/r/1556/diff
> 
> 
> Testing
> -------
> 
> Played through the easteregg a number of times to make sure it didn't explode under normal use conditions.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111101/26dadcef/attachment-0001.htm>


More information about the asterisk-dev mailing list