[asterisk-dev] [Code Review] chan_local locking cleanup

Alec Davis reviewboard at asterisk.org
Fri May 27 19:46:39 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1231/#review3647
-----------------------------------------------------------



/trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1231/#comment7331>

    I see red



/trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1231/#comment7329>

    missing space



/trunk/channels/chan_local.c
<https://reviewboard.asterisk.org/r/1231/#comment7330>

    +1? just 1 is fine


- Alec


On 2011-05-25 15:01:19, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1231/
> -----------------------------------------------------------
> 
> (Updated 2011-05-25 15:01:19)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Introduces the awesome_locking() function and cleans up all the unnecessary deadlock avoidance junk we do.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_local.c 320715 
> 
> Diff: https://reviewboard.asterisk.org/r/1231/diff
> 
> 
> Testing
> -------
> 
> I made a call. Obviously more testing is required under load.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110528/531c70fd/attachment-0001.htm>


More information about the asterisk-dev mailing list