[asterisk-dev] [Code Review] On demand AMI event filters

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1228/#review3644
-----------------------------------------------------------



trunk/main/manager.c
<https://reviewboard.asterisk.org/r/1228/#comment7319>

    Can you make these return values an enum instead of ints?



trunk/main/manager.c
<https://reviewboard.asterisk.org/r/1228/#comment7318>

    Put else on the same line as the closing brace


- Russell


On 2011-05-24 07:54:40, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1228/
> -----------------------------------------------------------
> 
> (Updated 2011-05-24 07:54:40)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> There is already support for white and black filters for AMI events in manager.conf, but they are defined statically.
> 
> It would be really great to be able to log in and add filters on the fly for just the current session.
> 
> 
> Diffs
> -----
> 
>   trunk/main/manager.c 320708 
> 
> Diff: https://reviewboard.asterisk.org/r/1228/diff
> 
> 
> Testing
> -------
> 
> ----------------------
> Test 1
> ----------------------
> 
> Log into AMI, events: all
> 
> Action: UserEvent
> UserEvent: foo
> MyValue: bar
> 
> (userevent recieved)
> 
> Action: FilterAdd
> Filter: !UserEvent: foo
> 
> Action: UserEvent
> UserEvent: foo
> MyValue: bar
> 
> (no foo userevent event received)
> 
> ----------------------
> Test 2
> ----------------------
> 
> Log into AMI session 1, events: all
> Log into AMI session 2, events: all
> 
> AMI session 1:
>   Action: FilterAdd
>   Filter: Event: PeerStatus
> 
>   (only peerstatus events received)
> 
> AMI session 2:
>   (all events received)
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110527/2e329e27/attachment.htm>