[asterisk-dev] [Code Review] Remove potential deadlock in call pickup race.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1234/
-----------------------------------------------------------

Review request for Asterisk Developers, Alec Davis and irroot.


Summary
-------

Fix potential deadlock in ast_do_pickup() with channels chan and target lock and channel container lock.

This should eliminate the deadlock avoidance code in https://reviewboard.asterisk.org/r/1118/ for issue 18830.

* Moved can_pickup() to ast_can_pickup() in features.c.


This addresses bugs 18654 and 18830.
    https://issues.asterisk.org/view.php?id=18654
    https://issues.asterisk.org/view.php?id=18830


Diffs
-----

  /branches/1.8/include/asterisk/features.h 321209 
  /branches/1.8/main/features.c 321209 
  /branches/1.8/apps/app_directed_pickup.c 321209 

Diff: https://reviewboard.asterisk.org/r/1234/diff


Testing
-------

Tested a simple call pickup to make sure that it at least still works.
Needs competing call pickup testing.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110526/32a6ccc6/attachment.htm>