[asterisk-dev] [Code Review] Fix *8 directed pickup locks system while sucessful pickupsound plays out.

[Alec Davis]

> On 2011-05-26 12:30:21, rmudgett wrote:
> > Looks like a good solution.  My only concern is that since there is a channel variable involved, someone's dialplan may be perverse enough to break.
> > 
> > How is the BRIDGE_PLAY_SOUND channel variable normally supposed to be used?

My train of thought was that ast_pickup_call can now only ever be invoked with the directed_pickup feature code, where no dialplan would be running.

Prior to the review 1185 changes dialplan "Pickup()" with pickupsounds enabled it would have beeped, if it ever worked.
But as we know this has been broken for a long time.


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1232/#review3628
-----------------------------------------------------------


On 2011-05-26 07:14:11, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1232/
> -----------------------------------------------------------
> 
> (Updated 2011-05-26 07:14:11)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> https://reviewboard.asterisk.org/r/1185/ finished off with the target channel requiring to be locked for the duration of the pickupsound, otherwise there was a clash between 2 threads trying to write data.
> 
> This simple change keeps the playout of the sucessful pickupsound in the same thread as the bridge, now played out by bridge_play_sounds().
> 
> 
> This addresses bug 18654.
>     https://issues.asterisk.org/view.php?id=18654
> 
> 
> Diffs
> -----
> 
>   trunk/main/features.c 320797 
> 
> Diff: https://reviewboard.asterisk.org/r/1232/diff
> 
> 
> Testing
> -------
> 
> yes, simple pickups with SIP and DAHDI, but to exaggerate the issue for testing purposes set pickupsound=tt_monkeys set in features.conf, and checking with 'core show locks' that no locks exist during playout. They do prior to this change.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110526/afd53abf/attachment-0001.htm>