[asterisk-dev] [Code Review] app_directed_pickup Implement the ability to remove a channel group on bridged channel

irroot reviewboard at asterisk.org
Thu May 26 03:58:56 CDT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-05-26 03:58:55.960893)

Review request for Asterisk Developers.


Updated patch once post pickup fix.

1)Is there any logic at looking at DOWN calls as pickup canditates ??
2)Deadlock avoidance is a proposal have come accross it in the wild possibly should not go in
3)Is there a better place to put the macro hooks ??


as a companion to 0018825 to aid with the move from call-limits to channel group variables. the problem with pickup and queue is that they manage channels outside the dialplan and need "helpers" to deal with channel groups.

in the case of pickup when a call is placed to a extension with say a "<EXTEN>@called" channel group when it is picked up this needs to be cleared to allow further calls when call waiting is disabled.

exten => s,n,GotoIf($[$[${ GROUP_COUNT(${ARG1}@called)} >= 1] | $[${GROUP_COUNT(${ARG1}@caller)} >= 1] | $[${GROUP_COUNT(${ARG1}@pickup)} >= 1] | $[${GROUP_COUNT(${ARG1}@qagent)} >= 1]]?s-BUSY,1)

caller is set when a call is placed.
called is set when a call is received
pickup is set when before calling pickup in the dialplan
qagent is set with patch to queue

Hope this is found to be useful and finds a home in trunk. 

not sure what time to put in the "wait for bridge" perhaps there is a better method ?? 

This addresses bug 18830.

Diffs (updated)

  /trunk/apps/app_directed_pickup.c 320772 
  /trunk/main/channel.c 320772 

Diff: https://reviewboard.asterisk.org/r/1118/diff




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110526/7df81df3/attachment.htm>

More information about the asterisk-dev mailing list