[asterisk-dev] [Code Review] The h exten is not run before closing CDR's. Interaction with active macro processing.

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1206/#review3544
-----------------------------------------------------------


The code looks great and from that standpoint I'm giving it a ship it.   However, I do not feel like I have the authority to comment on the behavior here.  It is unclear to me if the 'h' extension in the macro or the 'h' extension in the initial context should be given first priority.

- David


On 2011-05-12 11:15:23, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1206/
> -----------------------------------------------------------
> 
> (Updated 2011-05-12 11:15:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The h exten in the initial context is not run before closing CDR's when the bridge is unlinked if a macro is active and does not have an h exten.
> 
> This patch makes ast_bridge_call() check for an h exten in the current context and if a macro is active then the initial context.  The first h exten found is then run before closing the CDR.
> 
> 
> This addresses bug 18212.
>     https://issues.asterisk.org/view.php?id=18212
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/main/features.c 317385 
> 
> Diff: https://reviewboard.asterisk.org/r/1206/diff
> 
> 
> Testing
> -------
> 
> Tested with and without an h exten in the macro context.  The CDR was only modifiable when the bridge is unlinked if the h exten was in the macro context before the patch.  With the patch it is modifiable in the macro context and the initial context when the bridge is unlinked.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110513/5b91a80d/attachment.htm>