[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

irroot reviewboard at asterisk.org
Thu May 5 01:38:35 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-05 01:38:35.009966)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

ABI Compatibility changes.

seems that all thats left to do based on reviews to date ...

1)Dont hook into the bridge directly
2)Do something with the detected DTMF to switchover to T.38 GW

Greg


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405 and 19215.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215


Diffs (updated)
-----

  /trunk/res/res_fax_spandsp.c 316884 
  /trunk/channels/sip/include/sip.h 316884 
  /trunk/include/asterisk/channel.h 316884 
  /trunk/include/asterisk/res_fax.h 316884 
  /trunk/main/channel.c 316884 
  /trunk/res/res_fax.c 316884 
  /trunk/apps/app_faxdetect.c PRE-CREATION 
  /trunk/channels/chan_sip.c 316884 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110505/937c369e/attachment.htm>


More information about the asterisk-dev mailing list