[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[Matthew Nicholson]

> On 2011-04-30 12:47:29, irroot wrote:
> > /trunk/include/asterisk/channel.h, lines 1614-1621
> > <https://reviewboard.asterisk.org/r/1116/diff/9/?file=16297#file16297line1614>
> >
> >     Hi can someone help me out here i cant see a way of putting this into a framehook on one channel ... 
> >     
> >     the problem is these control frames are "eaten" by the bridge this precludes them from been used in a framehook ...
> >     
> >     i either have to leave this hook or run a framehook on both channels in the bridge...
> >     
> >     Thx

I'll look into this. Control frames should pass through the bridge and eventually get to the framehook. Modifications to the bridge function may be necessary to fix this.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3455
-----------------------------------------------------------


On 2011-05-03 07:43:12, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-05-03 07:43:12)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405 and 19215.
>     https://issues.asterisk.org/view.php?id=13405
>     https://issues.asterisk.org/view.php?id=19215
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_faxdetect.c PRE-CREATION 
>   /trunk/channels/chan_sip.c 316039 
>   /trunk/channels/sip/include/sip.h 316039 
>   /trunk/include/asterisk/channel.h 316039 
>   /trunk/include/asterisk/res_fax.h 316039 
>   /trunk/main/channel.c 316039 
>   /trunk/res/res_fax.c 316039 
>   /trunk/res/res_fax_spandsp.c 316039 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110504/d39c889c/attachment.htm>