[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3470
-----------------------------------------------------------


Overall this is a great improvement.  Some comments below.


/trunk/include/asterisk/res_fax.h
<https://reviewboard.asterisk.org/r/1116/#comment7133>

    If the handle_params function is not necessary, I don't think this is necessary either (see below). I'll look into this some more and let you know what I find.



/trunk/include/asterisk/res_fax.h
<https://reviewboard.asterisk.org/r/1116/#comment7131>

    These functions break ABI compatibility, which we would like to preserve. The functionality they provide can be implemented in the start_session(), write(), and destroy_session() functions.  They can determine the necessary action by checking for AST_FAX_TECH_GATEWAY in the details struct.



/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7128>

    event == AST_FRAMEHOOK_EVENT_ATTACHED is duplicated



/trunk/res/res_fax.c
<https://reviewboard.asterisk.org/r/1116/#comment7132>

    I am not sure this function is necessary or the handle_params function.  I'll investigate if it is possible to get rid of tomorrow.



/trunk/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/1116/#comment7130>

    Control frames should be processed in the framehook and should not be passed to this function.


There are some things I noted that I need to investigate and report back to you on tomorrow. Keep up the good work!

- Matthew


On 2011-05-03 07:43:12, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-05-03 07:43:12)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405 and 19215.
>     https://issues.asterisk.org/view.php?id=13405
>     https://issues.asterisk.org/view.php?id=19215
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_faxdetect.c PRE-CREATION 
>   /trunk/channels/chan_sip.c 316039 
>   /trunk/channels/sip/include/sip.h 316039 
>   /trunk/include/asterisk/channel.h 316039 
>   /trunk/include/asterisk/res_fax.h 316039 
>   /trunk/main/channel.c 316039 
>   /trunk/res/res_fax.c 316039 
>   /trunk/res/res_fax_spandsp.c 316039 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110504/7a914b0a/attachment-0001.htm>