[asterisk-dev] [Code Review] memcached utilities for asterisk dialplans

[Brad Latus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1139/#review3263
-----------------------------------------------------------


I would follow oej's view, it should be more like the DB functions since they do the same.
Also throughout the code your not following some of the CODING-GUIDELINES.txt
Main thing I noticed was that you declare variables all around the code, all variables must be declared at top of scope. 
You also have no message/default if people happen to specify an invalid or wrong hash function (at my quick look)

- Brad


On 2011-03-15 11:56:21, drivefast wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1139/
> -----------------------------------------------------------
> 
> (Updated 2011-03-15 11:56:21)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> memcached utilities for asterisk dialplans
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 310878 
>   /trunk/configs/memcached.conf.sample PRE-CREATION 
>   /trunk/configure.ac 310878 
>   /trunk/makeopts.in 310878 
>   /trunk/res/res_memcached.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1139/diff
> 
> 
> Testing
> -------
> 
> dialplan that touches all the functions and apps
> 
> 
> Thanks,
> 
> drivefast
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110329/a330f426/attachment.htm>