[asterisk-dev] [Code Review] Allow R/W of pickupgroup channel variable.

Russell Bryant reviewboard at asterisk.org
Fri Mar 25 09:19:54 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1148/#review3252
-----------------------------------------------------------


Please make sure all of your patches have an associated entry in mantis.  That's what gets it into our (Digium's) workflow to get it reviewed.

Also, since you've been writing a lot of patches lately, I think it makes sense to go ahead and set you up with commit access, as well.  You still need to get sign off through reviewboard before commit, though.  You can also use the access to maintain patches in developer branches.  Email me to get set up.

- Russell


On 2011-03-25 02:40:23, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1148/
> -----------------------------------------------------------
> 
> (Updated 2011-03-25 02:40:23)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> At first glance this is not needed but there is a application for it.
> 
> i have a large site that uses asterisk for all connections to trunks the existing legacy PBX is been phased out
> as it has no spares or capacity.
> 
> in the dialplan i want to allow call pickup if a call comes in on the DAHDI ports to the PBX i want to set the pickup group from
> the real time database and then run the pickup application this can be done with pickup mark this is not ideal as the SIP phones are using
> pickupgroup/changroup settings.
> 
> small change to allow reading / setting pickupgroup to help transition.
> 
> Greg 
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_channel.c 311674 
> 
> Diff: https://reviewboard.asterisk.org/r/1148/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110325/aa0a923c/attachment.htm>


More information about the asterisk-dev mailing list