[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-03-05 07:51:52.129032)


Review request for Asterisk Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

ok this patch actually works have not had a fax machine to test with now it works.

thx for the review Russell.

now that its functional ill be adding a option to FAXOPT to enable or disable the gateway ...

ill be looking into avoiding the loop for now it only is active when "switched over" and is as unobtrusive as possible when not switched over only handling T38 negotiation. 


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bug 13405.
    https://issues.asterisk.org/view.php?id=13405


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 309340 
  /trunk/channels/sip/include/sip.h 309340 
  /trunk/configs/sip.conf.sample 309340 
  /trunk/include/asterisk/channel.h 309340 
  /trunk/include/asterisk/res_fax.h 309340 
  /trunk/main/channel.c 309340 
  /trunk/res/res_fax.c 309340 
  /trunk/res/res_fax_spandsp.c 309340 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110305/d24e7d73/attachment.htm>