[asterisk-dev] [Code Review] dsp.c refactor section of dtmf_detect

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1130/#review3225
-----------------------------------------------------------



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/1130/#comment6699>

    Do we now need separate 'hit's and 'misses' counters? Could just be a single counter.
    We're either 'waiting for a new digit' or 'got a current digit and waiting to end'.
     


- Alec


On 2011-03-02 05:47:17, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1130/
> -----------------------------------------------------------
> 
> (Updated 2011-03-02 05:47:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In the process of trying to get DISA working with mobile phones, finished up cleaning a section of dtmf_detect.
> 
> 
> This addresses bug 18904.
>     https://issues.asterisk.org/view.php?id=18904
> 
> 
> Diffs
> -----
> 
>   trunk/main/dsp.c 309081 
> 
> Diff: https://reviewboard.asterisk.org/r/1130/diff
> 
> 
> Testing
> -------
> 
> Tested on 2 systems.
> system 1: On analog FXS connected phone, verified dtmf detection, is still valid.
> 
> system 2:. using callfile to call mobile, and then use DISA to sucessfully dial every time.
> 
> System 2: Debug logs (with dateformat=%F %T.%3q), show false triggers, with events triggered at appropriate times, 40ms.
> [2011-03-03 00:14:39.023] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.023] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.043] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.083] DEBUG[18627] dsp.c: DTMF BEG digit='2' len=0
> [2011-03-03 00:14:39.083] DEBUG[18627] chan_dahdi.c: Begin DTMF digit: 0x32 '2' on DAHDI/i1/021XXXXXX-1
> [2011-03-03 00:14:39.163] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.183] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.203] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.223] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.303] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.323] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.743] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.783] DEBUG[18627] dsp.c: DTMF END digit='2' len=4590
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110302/cd0abc05/attachment.htm>