[asterisk-dev] [Code Review] Set MWI on Register and restore lastmsgssent function

irroot reviewboard at asterisk.org
Thu Jun 30 06:33:33 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1272/
-----------------------------------------------------------

(Updated 2011-06-30 06:33:33.698348)


Review request for Asterisk Developers.


Changes
-------

The problem with lastmsgssent and realtime is that every time the cache expires the
value will be set to -1 on reload.

this addition to the patch checks the messages when the peer is loaded from DB

perhaps the following options would be better

1)store the lastmsgssent in astdb this is fine for a single server but this not portable
2)store the info in the users table

if they fail then use the method bellow.


Summary
-------

peer->lastmsgssent is never set ...

send MWI to peer on register reverting to previous behavior 


Diffs (updated)
-----

  /branches/1.8/channels/chan_sip.c 325799 

Diff: https://reviewboard.asterisk.org/r/1272/diff


Testing
-------

This works ans has been tested .... the problem with realtime is lastmsgssent is reset to -1 when
it is reloaded from db.

perhaps remove lastmsgssent completely ??


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110630/85305089/attachment-0001.htm>


More information about the asterisk-dev mailing list