[asterisk-dev] [Code Review] Read on idle timerfd will result in deadlocks

David Vossel reviewboard at asterisk.org
Wed Jun 29 13:50:18 CDT 2011



> On 2011-06-29 10:28:43, irroot wrote:
> > Been running for 2 days if there was going to be a issue it would have happened by now from experiance.
> > 
> > the logging should be changed to debug before commit as this has caused me problems in the past testing and
> > the testing has been done with ast_log commented out.
> > 
> > Greg

I'm going to commit this now. I'll clean up the logging.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1255/#review3785
-----------------------------------------------------------


On 2011-06-03 16:11:22, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1255/
> -----------------------------------------------------------
> 
> (Updated 2011-06-03 16:11:22)
> 
> 
> Review request for Asterisk Developers and russelb.
> 
> 
> Summary
> -------
> 
> Fix for issue https://issues.asterisk.org/view.php?id=18028
> And several others.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/res/res_timing_timerfd.c 320171 
> 
> Diff: https://reviewboard.asterisk.org/r/1255/diff
> 
> 
> Testing
> -------
> 
> Make enough calls to trigger a read on an idle timer
> 
> Wait for message:
> Reading attempt on idle timerfd. This would have caused a deadlock.
> 
> Deadlock avoided.
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110629/417b9504/attachment-0001.htm>


More information about the asterisk-dev mailing list