[asterisk-dev] [Code Review] Response to QueueRule manager command does not contain ActionID if it was specified

Russell Bryant reviewboard at asterisk.org
Wed Jun 29 10:16:30 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1295/#review3784
-----------------------------------------------------------

Ship it!


Looks good.  It looks like you removed docs though, is that intentional?

- Russell


On 2011-06-27 15:00:34, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1295/
> -----------------------------------------------------------
> 
> (Updated 2011-06-27 15:00:34)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Add ActionID support as documented for the QueueRule AMI action.
> 
> Also remove documentation for ActionID with the Queues AMI action.  The output does not follow normal AMI response output and there is no place to put an ActionID header.
> 
> This is a short patch that I am mainly interested in comments about the direction of resolution.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_queue.c 325025 
> 
> Diff: https://reviewboard.asterisk.org/r/1295/diff
> 
> 
> Testing
> -------
> 
> The Response and ActionID headers are output for the QueueRule AMI action.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110629/966644ab/attachment-0001.htm>


More information about the asterisk-dev mailing list