[asterisk-dev] [Code Review] Add ChanCallerID Variable to Set CallerID Sent to Originating Device on Manager Originate Action

[jamuel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1289/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

When initiating an AMI Originate event the Caller ID sent to the originating channel (Calling Party) is not settable in the manager action.  As a result the originating channel is sent CallerID containing the calling device's name.  This patch adds a new variable (ChanCallerID) to the Originate action so that any CallerID can be arbitrarily sent to the originator.  If the variable is not set then the original behavior is maintained.  ChanCallerID should be specified as a regular asterisk callerid value (e.g. Jamuel Starkey <4152000404>).

This patch useful for CTI app's that perform dialing for the user via AMI so that the name and number sent to the originator could be any useful value (e.g. the called party CID).


Diffs
-----

  http://svn.asterisk.org/svn/asterisk/trunk/main/manager.c 324908 

Diff: https://reviewboard.asterisk.org/r/1289/diff


Testing
-------

Tested both with/without async set (i.e. fast_originate).  Expected CallerID received on the calling party's display when variable ChanCallerID set.  Tested with SIP devices only (Eyebeam and Polycom Soundpoint IP).

Here's a sample originate action with the CallerID sent to the calling party set to Movie Phone <4157773456>:

Action: Originate
Channel: SIP/SOFTPHONE
Exten: 4157773456
Context: from-internal
Priority: 1
CallerID: Jamuel Starkey <4152000400>
Variable: AMPUSER=SOFTPHONE,REALCALLERIDNUM=SOFTJPS,ChanCallerID=Moviefone <4157773456>
Async: True


Thanks,

jamuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110626/842f8b1a/attachment.htm>