[asterisk-dev] [Code Review] sip_tls_call test added to external test suite

[jrose]

> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/sip.conf, line 22
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17089#file17089line22>
> >
> >     tlsbindaddr=127.0.0.2:5060

As above.


> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/sip.conf, line 22
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17086#file17086line22>
> >
> >     tlsbindaddr=127.0.0.1:5060

Check.


> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/sip.conf, lines 6-7
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17086#file17086line6>
> >
> >     This can be removed

Check.


> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/sip.conf, line 4
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17086#file17086line4>
> >
> >     updbindaddr=127.0.0.1:5060

Check.


> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/sip.conf, lines 6-7
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17089#file17089line6>
> >
> >     Can be removed

Check.


> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/sip.conf, line 4
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17089#file17089line4>
> >
> >     udpbindaddr=127.0.0.2:5060

I don't think I can bind the same port to both running instances of Asterisk safely.  Running the test while trying to do that spits out weird agi errors even though I got rid of the AGI stuff.

For now, I've changed it to 127.0.0.2:5061, which seems to work fine.


> On 2011-06-22 19:49:43, Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/sip.conf, line 31
> > <https://reviewboard.asterisk.org/r/1276/diff/3/?file=17089#file17089line31>
> >
> >     Again, same comment about secret

All secret stuff fixed up.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1276/#review3768
-----------------------------------------------------------


On 2011-06-21 12:33:58, jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1276/
> -----------------------------------------------------------
> 
> (Updated 2011-06-21 12:33:58)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, David Vossel, and Paul Belanger.
> 
> 
> Summary
> -------
> 
> First, you can ignore the text files.  spacespacespace.txt was just used while I was working out shell command stuff and I accidentally added it to this diff and I've also removed test-output.txt.
> 
> I'm still not perfectly sure how this is going to work with the cert files.  I'd guess it'll be fine regardless of the machine, but I haven't tested this on another machine yet that didn't create these cert files.
> 
> This test uses the basic-call test in IAX2 as a base.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/manager.general.conf.inc PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/helper1 PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/helper2 PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/ca.cfg PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/ca.crt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/ca.key PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverA.crt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverA.csr PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverA.key PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverA.pem PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverB.crt PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverB.csr PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverB.key PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/serverB.pem PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/configs/keys/tmp.cfg PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_tls_call/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 1657 
>   /asterisk/trunk/tests/tests.yaml 1657 
> 
> Diff: https://reviewboard.asterisk.org/r/1276/diff
> 
> 
> Testing
> -------
> 
> How did I test the test?  Mostly by checking the sip debug logs to make sure the call was going through as a SIP/TLS call.  The usual flow of SIP messages was there and it resembled my regular SIP/TLS calls.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110623/7a69147d/attachment-0001.htm>