[asterisk-dev] [Code Review] Read on idle timerfd will result in deadlocks

[kobaz]

> On 2011-06-06 12:35:19, David Vossel wrote:
> > branches/1.8/res/res_timing_timerfd.c, line 189
> > <https://reviewboard.asterisk.org/r/1255/diff/2/?file=16826#file16826line189>
> >
> >     I know Russell already commented about the logging but just to be a little more explicit, please don't put the words "avoiding deadlock" into any sort of log or debug message.  That has caused some confusion in the past.

Is the message "this would have caused a deadlock" okay?


- kobaz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1255/#review3682
-----------------------------------------------------------


On 2011-06-03 16:11:22, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1255/
> -----------------------------------------------------------
> 
> (Updated 2011-06-03 16:11:22)
> 
> 
> Review request for Asterisk Developers and russelb.
> 
> 
> Summary
> -------
> 
> Fix for issue https://issues.asterisk.org/view.php?id=18028
> And several others.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/res/res_timing_timerfd.c 320171 
> 
> Diff: https://reviewboard.asterisk.org/r/1255/diff
> 
> 
> Testing
> -------
> 
> Make enough calls to trigger a read on an idle timer
> 
> Wait for message:
> Reading attempt on idle timerfd. This would have caused a deadlock.
> 
> Deadlock avoided.
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110617/61e1cdb0/attachment.htm>