[asterisk-dev] [Code Review] Set MWI on Register and restore lastmsgssent function

[irroot]

> On 2011-06-16 17:06:33, irroot wrote:
> > /team/irroot/distrotech-customers-1.8/channels/chan_sip.c, lines 24777-24783
> > <https://reviewboard.asterisk.org/r/1272/diff/5/?file=17021#file17021line24777>
> >
> >     This is not right returns -1 wrong
> 
> Tilghman Lesher wrote:
>     I think you mean if it IS zero length, return -1.  Take out the '!'.

Indeed had the logic inverted initially ... to prevent sending a 0/0 message when no mailbox existed.


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1272/#review3741
-----------------------------------------------------------


On 2011-06-16 17:14:25, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1272/
> -----------------------------------------------------------
> 
> (Updated 2011-06-16 17:14:25)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> peer->lastmsgssent is never set ...
> 
> send MWI to peer on register reverting to previous behavior 
> 
> 
> Diffs
> -----
> 
>   /team/irroot/distrotech-customers-1.8/channels/chan_sip.c 323469 
> 
> Diff: https://reviewboard.asterisk.org/r/1272/diff
> 
> 
> Testing
> -------
> 
> This works ans has been tested .... the problem with realtime is lastmsgssent is reset to -1 when
> it is reloaded from db.
> 
> perhaps remove lastmsgssent completely ??
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110616/cffca0a1/attachment-0001.htm>