[asterisk-dev] [Code Review] Set MWI on Register and restore lastmsgssent function

[Tilghman Lesher]

> On 2011-06-16 15:26:15, David Vossel wrote:
> > /team/irroot/distrotech-customers-1.8/channels/chan_sip.c, lines 14377-14381
> > <https://reviewboard.asterisk.org/r/1272/diff/1/?file=17003#file17003line14377>
> >
> >     What happens if this peer doesn't have a mailbox?
> 
> irroot wrote:
>     The count comes from underlying functions in app_voicemail and has a strlen_zero check.
> 
> David Vossel wrote:
>     Right, so if a peer doesn't have a mailbox what happens.  nummsgs and oldmsgs are both 0 because the mailbox didn't exist, but does some MWI message get sent out saying they don't have any messages even though they don't have a mailbox?
> 
> irroot wrote:
>     Ok small change coming up that causes it to have no effect if there is no mailbox.
>     
>     previously would send notify with 0/0

Consider the case where a phone previously has a mailbox set, the mailbox is unset, and a reload is performed.  Shouldn't the peer get a message telling it to clear its MWI notifications?  If you make that change, would the phone forever assume that messages are still there?


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1272/#review3735
-----------------------------------------------------------


On 2011-06-16 16:46:26, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1272/
> -----------------------------------------------------------
> 
> (Updated 2011-06-16 16:46:26)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> peer->lastmsgssent is never set ...
> 
> send MWI to peer on register reverting to previous behavior 
> 
> 
> Diffs
> -----
> 
>   /team/irroot/distrotech-customers-1.8/channels/chan_sip.c 323469 
> 
> Diff: https://reviewboard.asterisk.org/r/1272/diff
> 
> 
> Testing
> -------
> 
> This works ans has been tested .... the problem with realtime is lastmsgssent is reset to -1 when
> it is reloaded from db.
> 
> perhaps remove lastmsgssent completely ??
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110616/a2e314aa/attachment.htm>